diff options
| author | ewolinetz <ewolinet@redhat.com> | 2017-01-18 15:29:00 -0600 |
|---|---|---|
| committer | ewolinetz <ewolinet@redhat.com> | 2017-01-18 15:29:00 -0600 |
| commit | e71c29687d12a4a5e88b7cffcece634816b1e1e5 (patch) | |
| tree | ee1b0293ac85e2a555fc64566c866d3e4e64362e | |
| parent | e23e9bf557c883d294462e76bdd9399520b01ebc (diff) | |
| download | openshift-e71c29687d12a4a5e88b7cffcece634816b1e1e5.tar.gz openshift-e71c29687d12a4a5e88b7cffcece634816b1e1e5.tar.bz2 openshift-e71c29687d12a4a5e88b7cffcece634816b1e1e5.tar.xz openshift-e71c29687d12a4a5e88b7cffcece634816b1e1e5.zip | |
Addressing found issues with logging role
| -rw-r--r-- | roles/openshift_logging/library/openshift_logging_facts.py | 4 | ||||
| -rw-r--r-- | roles/openshift_logging/tasks/generate_configmaps.yaml | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/roles/openshift_logging/library/openshift_logging_facts.py b/roles/openshift_logging/library/openshift_logging_facts.py index 8bbfdf7bf..64bc33435 100644 --- a/roles/openshift_logging/library/openshift_logging_facts.py +++ b/roles/openshift_logging/library/openshift_logging_facts.py @@ -105,9 +105,9 @@ class OpenshiftLoggingFacts(OCBaseCommand): def add_facts_for(self, comp, kind, name=None, facts=None): ''' Add facts for the provided kind ''' - if comp in self.facts is False: + if comp not in self.facts: self.facts[comp] = dict() - if kind in self.facts[comp] is False: + if kind not in self.facts[comp]: self.facts[comp][kind] = dict() if name: self.facts[comp][kind][name] = facts diff --git a/roles/openshift_logging/tasks/generate_configmaps.yaml b/roles/openshift_logging/tasks/generate_configmaps.yaml index b24a7c342..8fcf517ad 100644 --- a/roles/openshift_logging/tasks/generate_configmaps.yaml +++ b/roles/openshift_logging/tasks/generate_configmaps.yaml @@ -49,7 +49,7 @@ - copy: content: "{{curator_config_contents}}" dest: "{{mktemp.stdout}}/curator.yml" - when: curator_config_contenets is defined + when: curator_config_contents is defined changed_when: no - command: > |