summaryrefslogtreecommitdiffstats
path: root/playbooks/common/openshift-node/service.yml
diff options
context:
space:
mode:
authorRussell Teague <rteague@redhat.com>2017-01-25 14:29:15 -0500
committerRussell Teague <rteague@redhat.com>2017-01-25 14:29:15 -0500
commit83ec5ce228c769fd7252600961fa5b142af00cd9 (patch)
treec94d2bad8e15e3279afe963f14312e81af194c4f /playbooks/common/openshift-node/service.yml
parentd8fee0cc8441812cdd5e7aaae815adad7a9bbee7 (diff)
downloadopenshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.gz
openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.bz2
openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.tar.xz
openshift-83ec5ce228c769fd7252600961fa5b142af00cd9.zip
Standardize add_host: with name and changed_when
The add_host: task does not change any data on the host and as practice has been configured to changed_when: False. This commit standardizes that usage in the byo and common playbooks. Additionally, taks names are added to each task to improve troubleshooting.
Diffstat (limited to 'playbooks/common/openshift-node/service.yml')
-rw-r--r--playbooks/common/openshift-node/service.yml10
1 files changed, 8 insertions, 2 deletions
diff --git a/playbooks/common/openshift-node/service.yml b/playbooks/common/openshift-node/service.yml
index 2da68ceea..130a5416f 100644
--- a/playbooks/common/openshift-node/service.yml
+++ b/playbooks/common/openshift-node/service.yml
@@ -9,12 +9,18 @@
when: new_cluster_state is not defined
- name: Evaluate g_service_nodes
- add_host: name={{ item }} groups=g_service_nodes
+ add_host:
+ name: "{{ item }}"
+ groups: g_service_nodes
with_items: "{{ oo_host_group_exp | default([]) }}"
+ changed_when: False
- name: Change state on node instance(s)
hosts: g_service_nodes
connection: ssh
gather_facts: no
tasks:
- - service: name={{ service_type }}-node state="{{ new_cluster_state }}"
+ - name: Change state on node instance(s)
+ service:
+ name: "{{ service_type }}-node"
+ state: "{{ new_cluster_state }}"