diff options
| author | Kenny Woodson <kwoodson@redhat.com> | 2017-08-09 10:45:55 -0400 |
|---|---|---|
| committer | Kenny Woodson <kwoodson@redhat.com> | 2017-08-09 10:45:55 -0400 |
| commit | ba96f5eaf876f6b7568ac73794a08cbe759dceee (patch) | |
| tree | ef9a38f8352079988a3ba08e4f4731f3c37de879 /roles/cockpit | |
| parent | 4f9b26e8af5890b7960291497020586426e7f1fc (diff) | |
| download | openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.gz openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.bz2 openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.tar.xz openshift-ba96f5eaf876f6b7568ac73794a08cbe759dceee.zip | |
Adding a default condition and removing unneeded defaults.
Diffstat (limited to 'roles/cockpit')
| -rw-r--r-- | roles/cockpit/defaults/main.yml | 1 | ||||
| -rw-r--r-- | roles/cockpit/tasks/firewall.yml | 8 |
2 files changed, 4 insertions, 5 deletions
diff --git a/roles/cockpit/defaults/main.yml b/roles/cockpit/defaults/main.yml index d8231eced..97b00db04 100644 --- a/roles/cockpit/defaults/main.yml +++ b/roles/cockpit/defaults/main.yml @@ -3,4 +3,3 @@ r_cockpit_os_firewall_deny: [] r_cockpit_os_firewall_allow: - service: cockpit-ws port: 9090/tcp - cond: true diff --git a/roles/cockpit/tasks/firewall.yml b/roles/cockpit/tasks/firewall.yml index b60cf7b28..0e253a9f5 100644 --- a/roles/cockpit/tasks/firewall.yml +++ b/roles/cockpit/tasks/firewall.yml @@ -7,7 +7,7 @@ action: add protocol: "{{ item.port.split('/')[1] }}" port: "{{ item.port.split('/')[0] }}" - when: item.cond + when: item.cond | default(True) with_items: "{{ r_cockpit_os_firewall_allow }}" - name: Remove iptables rules @@ -16,7 +16,7 @@ action: remove protocol: "{{ item.port.split('/')[1] }}" port: "{{ item.port.split('/')[0] }}" - when: item.cond + when: item.cond | default(True) with_items: "{{ r_cockpit_os_firewall_deny }}" - when: os_firewall_enabled | bool and os_firewall_use_firewalld | bool @@ -27,7 +27,7 @@ permanent: true immediate: true state: enabled - when: item.cond + when: item.cond | default(True) with_items: "{{ r_cockpit_os_firewall_allow }}" - name: Remove firewalld allow rules @@ -36,5 +36,5 @@ permanent: true immediate: true state: disabled - when: item.cond + when: item.cond | default(True) with_items: "{{ r_cockpit_os_firewall_deny }}" |